Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check all modules builds. #11

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

thresheek
Copy link
Member

While suboptimal and can be improved in future, I believe this is now needed to test if the modules compile at all.

@thresheek thresheek requested a review from oxpa October 21, 2024 23:09
@oxpa
Copy link
Contributor

oxpa commented Oct 22, 2024

I would prefer having arguments to cut in quotes, rather than escaped (so cut -d ' ' instead of cut -d\ ). Though up to you.

@thresheek
Copy link
Member Author

Thanks, I've changed the cut invocation to use quotes. I'll let the CI finish and will merge afterwards.

@thresheek thresheek merged commit c17de79 into nginx:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants