Correct typo in helm lease annotations template #7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
added
helm_chart
pdabelf5
added
bug
pdabelf5
changed the title
vepatel
approved these changes
Jan 22, 2025
…1b646de471c235f748e734dc3a0
AlexFenlon
approved these changes
Jan 22, 2025
pdabelf5
deleted the
cherry-pick-release-4.0-ec4aceeb5984a1b646de471c235f748e734dc3a0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The syntax for the helm template
controller-lease.yamlwas incorrect for annotations. This change addresses the issue by adding the required:to make the yaml valid.Checklist
Before creating a PR, run through this checklist and mark each as complete.