-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow securityContext and podSecurityContext to be configurable via helm parameters #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Pull requests for new features/feature enhancements
helm_chart
Pull requests that update the Helm Chart
labels
Feb 13, 2024
github-actions
bot
added
the
documentation
Pull requests/issues for documentation
label
Feb 13, 2024
oseoin
reviewed
Feb 13, 2024
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
Jcahilltorre
approved these changes
Feb 13, 2024
oseoin
reviewed
Feb 19, 2024
oseoin
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
helm_chart
Pull requests that update the Helm Chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow securityContext and podSecurityContext to be configurable via helm parameters, so users have the flexibility to configure k8s properties like
allowPrivilegeEscalation
,capabilities
etc.Defaults are same as last release but user can modify as shown below:
values.yaml
generated pod spec:
Checklist
Before creating a PR, run through this checklist and mark each as complete.