feat: Update pull request template #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the spacing issue of the pull request checklist by changing the final checklist item. The relevant information now exists as a sentence after the list, as well as an additional line. The additional line, alongside a similar one added to the checklist, direct the reader to our style guide to review specific guidance that would otherwise be too verbose to add to the template.
This commit fixes the spacing issue of the pull request checklist by changing the final checklist item. The relevant information now exists as a sentence after the list, as well as an additional line. The additional line, alongside a similar one added to the checklist, direct the reader to our style guide to review specific guidance that would otherwise be too verbose to add to the template.
…nto update-pr-template
✅ Deploy Preview will be available once build job completes!
|
Jcahilltorre
approved these changes
Jan 7, 2025
mjang
reviewed
Jan 10, 2025
travisamartin
approved these changes
Jan 10, 2025
mjang
requested changes
Jan 12, 2025
mjang
reviewed
Jan 12, 2025
Jcahilltorre
approved these changes
Jan 22, 2025
|
@mjang I suggest to merge this PR with the current improvements and move the conversation about further improvements into a separate conversation/PR |
mjang
reviewed
Jan 22, 2025
mjang
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit fixes the spacing issue of the pull request checklist by
changing the final checklist item. The relevant information now exists
as a sentence after the list, as well as an additional line.
The additional line, alongside a similar one added to the checklist,
direct the reader to our style guide to review specific guidance that
would otherwise be too verbose to add to the template.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
I have read the contributing guidelines
I have signed the F5 Contributor License Agreement (CLA)
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (
README.mdandCHANGELOG.md)I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
If the change involves:
<username>in place of PIIIn these cases, the change will require at least two (2) approvals before merging