Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTel tcplog receiver for NAP #932

Merged
merged 17 commits into from
Dec 20, 2024
Merged

Add OTel tcplog receiver for NAP #932

merged 17 commits into from
Dec 20, 2024

Conversation

RRashmit
Copy link

@RRashmit RRashmit commented Nov 18, 2024 •
edited by dhurley
Loading

Proposed changes

  • Adds the otel tcplog receiver to collect the syslog logs generated by NAP.
  • Add a log pipeline to OTel collector.
  • Parse NGINX config to discover NAP syslog locations and dynamically update the log pipeline in the OTel collector.
  • Add resource attributes reource.id and instance.id to log messages.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@RRashmit RRashmit requested a review from a team as a code owner November 18, 2024 10:17
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 18, 2024
@RRashmit RRashmit changed the title Add OTEL Syslog receiver to Agent v3 Adds OTEL Syslog receiver to Agent v3 Nov 18, 2024
@RRashmit RRashmit self-assigned this Nov 18, 2024
@RRashmit RRashmit added enhancement New feature or request and removed chore Pull requests for routine tasks labels Nov 18, 2024
@RRashmit RRashmit marked this pull request as draft November 18, 2024 10:28
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 18, 2024
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Nov 20, 2024
@dhurley dhurley changed the title Adds OTEL Syslog receiver to Agent v3 Add OTEL tcplog receiver Nov 28, 2024
@dhurley dhurley changed the title Add OTEL tcplog receiver Add OTel tcplog receiver Nov 28, 2024
@dhurley dhurley self-assigned this Nov 28, 2024
@dhurley dhurley marked this pull request as ready for review November 28, 2024 17:16
@dhurley dhurley changed the title Add OTel tcplog receiver Add OTel tcplog receiver for NAP Nov 28, 2024
@dhurley dhurley merged commit d64f32b into v3 Dec 20, 2024
20 checks passed
@dhurley dhurley deleted the poc-v3-otel-syslog branch December 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigell craigell craigell approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@dhurley dhurley

@RRashmit RRashmit

Labels
chore Pull requests for routine tasks dependencies enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RRashmit @oliveromahony @craigell @oCHRISo @dhurley