Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that integration tests pass before making a release #921

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

RRashmit
Copy link

@RRashmit RRashmit commented Nov 8, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@RRashmit RRashmit requested a review from a team as a code owner November 8, 2024 12:26
@dhurley
Copy link
Collaborator

dhurley commented Nov 8, 2024

Could you update the title of the PR to something like this?
Add check that integration tests pass before making a release

@RRashmit RRashmit changed the title chore: add missed integration test Add check that integration tests pass before making a release Nov 8, 2024
@RRashmit RRashmit self-assigned this Nov 8, 2024
@RRashmit RRashmit added the v3.x Issues and Pull Requests related to the major version v3 label Nov 8, 2024
@RRashmit RRashmit merged commit 2a9548f into v3 Nov 8, 2024
20 checks passed
@RRashmit RRashmit deleted the publish-packages-job branch November 8, 2024 15:11
sean-breen pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants