Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Agent connection to mpi regardless of NGINX Instance status #916

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Add support for Agent connection to mpi regardless of NGINX Instance status #916

merged 9 commits into from
Nov 8, 2024

Conversation

RRashmit
Copy link

@RRashmit RRashmit commented Nov 6, 2024

Proposed changes

Made Agent to connect connect to the management plane regardless of NGINX Instance status

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@RRashmit RRashmit requested a review from a team as a code owner November 6, 2024 15:53
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 6, 2024
@RRashmit RRashmit self-assigned this Nov 6, 2024
@RRashmit RRashmit added the v3.x Issues and Pull Requests related to the major version v3 label Nov 6, 2024
@oCHRISo oCHRISo added enhancement New feature or request and removed chore Pull requests for routine tasks labels Nov 7, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2024
@RRashmit RRashmit removed the chore Pull requests for routine tasks label Nov 8, 2024
@RRashmit RRashmit merged commit 399bf5c into v3 Nov 8, 2024
20 checks passed
@RRashmit RRashmit deleted the agent-connection-to-mpi branch November 8, 2024 16:01
sean-breen pushed a commit that referenced this pull request Nov 11, 2024
@RRashmit @sean-breen
Add support for Agent connection to mpi regardless of NGINX Instance …
376eab4 
…status (#916)

* chore: allow commander service to connect irrespective of nginx availability

* chore: unit test

* chore: integration test

* chore: refactored

* chore: remove extra code

* chore: updated build target

* chore: updating variables

* chore: separated nginx less test from official agent testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@sean-breen sean-breen sean-breen approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@RRashmit RRashmit

Labels
enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RRashmit @oliveromahony @dhurley @craigell @sean-breen @aphralG @oCHRISo