Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detail to subject and issuer #915

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Add more detail to subject and issuer #915

merged 6 commits into from
Nov 8, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Add more fields to subject and issuer so that they conform to https://pkg.go.dev/crypto/x509/pkix#Name

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@oliveromahony oliveromahony requested a review from a team as a code owner November 6, 2024 14:54
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Nov 6, 2024
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Nov 7, 2024
@oliveromahony oliveromahony merged commit 3087241 into v3 Nov 8, 2024
20 checks passed
@oliveromahony oliveromahony deleted the fix-subject-issuer branch November 8, 2024 13:02
sean-breen pushed a commit that referenced this pull request Nov 11, 2024
@oliveromahony @sean-breen
Add more detail to subject and issuer (#915)
149f108 
* added cert meta for subject and issuer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRashmit RRashmit RRashmit approved these changes

@aphralG aphralG aphralG approved these changes

@sean-breen sean-breen sean-breen approved these changes

@dhurley dhurley dhurley approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oliveromahony @dhurley @sean-breen @aphralG @RRashmit @oCHRISo