Add support for Management Plane Health Request #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
reviewed
Oct 25, 2024
dhurley
reviewed
Oct 25, 2024
internal/bus/topics.go
Outdated
Comment on lines
24
to
25
| DataplaneHealthTopic = "dataplane-health" | ||
| DataplaneHealthProcessTopic = "dataplane-health-process" |
There was a problem hiding this comment.
Suggested change
| DataplaneHealthTopic = "dataplane-health" | |
| DataplaneHealthProcessTopic = "dataplane-health-process" | |
| DataplaneHealthRequestTopic = "dataplane-health-request" | |
| DataplaneHealthResponseTopic = "dataplane-health-response" |
Maybe request & response might be better names for the topics?
| isApplyRequest: true, | ||
| }, | ||
| { | ||
| name: "Test 3: Config Health Request", |
There was a problem hiding this comment.
Suggested change
| name: "Test 3: Config Health Request", | |
| name: "Test 3: Health Request", |
| Request: &mpi.ManagementPlaneRequest_ConfigUploadRequest{ | ||
| ConfigUploadRequest: &mpi.ConfigUploadRequest{}, | ||
| tests := []struct { | ||
| mpiRequest *mpi.ManagementPlaneRequest |
There was a problem hiding this comment.
Suggested change
| mpiRequest *mpi.ManagementPlaneRequest | |
| managementPlaneRequest *mpi.ManagementPlaneRequest |
|
|
||
| assert.Equal(t, mpi.CommandResponse_COMMAND_STATUS_OK, responses[0].GetCommandResponse().GetStatus()) | ||
| assert.Equal(t, mpi.CommandResponse_COMMAND_STATUS_OK, responses[1].GetCommandResponse().GetStatus()) | ||
| assert.Contains(t, allMessages, "Successfully sent the health status update") |
There was a problem hiding this comment.
Probably better to check the message for each response
aphralG
reviewed
Oct 25, 2024
aphralG
reviewed
Oct 25, 2024
aphralG
approved these changes
Nov 5, 2024
dhurley
reviewed
Nov 5, 2024
pkg/config/features.go
Outdated
| @@ -15,4 +15,5 @@ const ( | |||
| FeatureMetricsInstance = "metrics-instance" | |||
| FeatureFileWatcher = "file-watcher" | |||
| FeatureAgentAPI = "agent-api" | |||
| FeatureDataplaneHealth = "dataplane-health" | |||
There was a problem hiding this comment.
Don't think you need to add this feature. The constant isn't being used anywhere.
There was a problem hiding this comment.
Thought, I'd removed it, added it initially.
RRashmit
changed the title
dhurley
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the health responses to mpi when it receives an mpi request for health status.
Tested the api:
Flow of request & response
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)