Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APK package names #881

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix APK package names #881

merged 2 commits into from
Oct 3, 2024

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Oct 1, 2024

Proposed changes

Package name needs to have underscores instead of dashes otherwise we get this error when installing

1.100 ERROR: nginx-agent-3.0.0_3: package mentioned in index not found (try 'apk update')

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Oct 1, 2024
@dhurley dhurley requested a review from a team as a code owner October 1, 2024 15:29
@github-actions github-actions bot added the bug Something isn't working label Oct 1, 2024
@dhurley dhurley self-assigned this Oct 1, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 3, 2024
@dhurley dhurley merged commit 6f729fa into v3 Oct 3, 2024
20 checks passed
@dhurley dhurley deleted the fix-apk-package-names branch October 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@dhurley dhurley

Labels
bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhurley @oliveromahony @aphralG