-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default set of features to Agent Configuration #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Pull requests for routine tasks
enhancement
New feature or request
labels
Sep 25, 2024
oliveromahony
changed the title
added feature set
Added default set of features to Agent Configuration
Sep 25, 2024
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 26, 2024
dhurley
approved these changes
Sep 26, 2024
aphralG
reviewed
Sep 27, 2024
aphralG
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
documentation
Improvements or additions to documentation
enhancement
New feature or request
v3.x
Issues and Pull Requests related to the major version v3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding default set of feature flags to enable refactoring of Agent Configuration properly.
This is the basics for the design of a feature flag management system for the NGINX Agent. The system enables dynamic toggling of features based on configurations provided via multiple sources, including CLI parameters, environment variables, configuration files, and via protobuf gRPC messages. Feature flags control the execution paths within the application, allowing for flexible and controlled feature management.
Feature Overview:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)