Update go version to 1.23 #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
RRashmit
approved these changes
Sep 25, 2024
6 tasks
dhurley
approved these changes
Oct 1, 2024
sean-breen
pushed a commit
that referenced
this pull request
Oct 11, 2024
sean-breen
added a commit
that referenced
this pull request
Oct 21, 2024
* add attribute processor to config, handle resource update to get id * write configuration before reloading * update template file handling of attributes processor * add attribute processor to mock config * add more nil checks for attribute processor * fix linting errors * commit generated files * fix debug exporter in template * Use slice of Actions in Attributes processor * fix lint: tag alignment * remove docker login, use prod container repo for OSS nginx * add unit test for processing ResourceUpdateTopic * Update mdatagen install instructions in README.md (#887) * Update go version to 1.23 (#865) * Agent Config Changes: rename & update config_dirs & update exclude_logs (#882) * max api version (#880) * add log to inetgration test (#893) * add lock for restarting OTel collector * fix struct alignment * new proto defs * resource-id -> resource.id * fix lint: remove trailing newline * fix unit test * add unit test for negative case * address pr feedback * add updateResourceAttributes function + unit tests * add nolint for cognitive-complexity, pending review * fix nolint * more feedback * fix test condition * PR feedback --------- Co-authored-by: Donal Hurley <[email protected]> Co-authored-by: oliveromahony <[email protected]> Co-authored-by: aphralG <[email protected]>
sean-breen
added a commit
that referenced
this pull request
Oct 24, 2024
* add attribute processor to config, handle resource update to get id * write configuration before reloading * update template file handling of attributes processor * add attribute processor to mock config * add more nil checks for attribute processor * fix linting errors * commit generated files * fix debug exporter in template * Use slice of Actions in Attributes processor * fix lint: tag alignment * remove docker login, use prod container repo for OSS nginx * add unit test for processing ResourceUpdateTopic * Update mdatagen install instructions in README.md (#887) * Update go version to 1.23 (#865) * Agent Config Changes: rename & update config_dirs & update exclude_logs (#882) * max api version (#880) * add log to inetgration test (#893) * add lock for restarting OTel collector * fix struct alignment * new proto defs * resource-id -> resource.id * fix lint: remove trailing newline * fix unit test * add unit test for negative case * address pr feedback * add updateResourceAttributes function + unit tests * add nolint for cognitive-complexity, pending review * fix nolint * more feedback * fix test condition * add resource for each scraper * adding instance id to otel metadata config * PR feedback * add instance id and type to nginxplus receiver otel resource * add instance id and type to otel resource - nginx oss log scraper - nginx oss stub status scraper - nginx plus api scraper * fix lint errors * run gofumpt * update go.mod * remove comment * Fix unit test expected files * increase timeout by 1 sec * format * nginx.instance.* to instance.* * PR feedback * increase timeout values for collector plugin test * Update internal/collector/nginxplusreceiver/scraper.go Co-authored-by: Donal Hurley <[email protected]> * Update internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper.go Co-authored-by: Donal Hurley <[email protected]> * Update internal/collector/nginxossreceiver/internal/scraper/accesslog/nginx_log_scraper.go Co-authored-by: Donal Hurley <[email protected]> --------- Co-authored-by: Donal Hurley <[email protected]> Co-authored-by: oliveromahony <[email protected]> Co-authored-by: aphralG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the go version to version 1.23
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)