Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix make stop-mock-management-otel-collector #848

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix make stop-mock-management-otel-collector #848

merged 1 commit into from
Sep 18, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 17, 2024

Proposed changes

Fix make stop-mock-management-otel-collector

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG added the v3.x Issues and Pull Requests related to the major version v3 label Sep 17, 2024
@aphralG aphralG self-assigned this Sep 17, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 17, 2024
@aphralG aphralG merged commit 373df4b into v3 Sep 18, 2024
20 checks passed
@aphralG aphralG deleted the fix-stop-otel-collector-make-target branch September 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRashmit RRashmit RRashmit approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@CVanF5 CVanF5 Awaiting requested review from CVanF5

@sean-breen sean-breen Awaiting requested review from sean-breen

Assignees

@aphralG aphralG

Labels
bug Something isn't working v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @dhurley @craigell @RRashmit