Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running config validation when file action fails #840

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Avoid running config validation when file action fails #840

merged 7 commits into from
Sep 17, 2024

Conversation

sean-breen
Copy link

@sean-breen sean-breen commented Sep 13, 2024 •
edited
Loading

Proposed changes

This change alters the handling of the model.RollbackRequired status in the file plugin to avoid running the validation step in cases where a config apply fails due to a file operation error.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 13, 2024
@sean-breen sean-breen marked this pull request as ready for review September 13, 2024 15:00
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Sep 16, 2024
@sean-breen sean-breen requested a review from RRashmit September 17, 2024 09:10
RRashmit
RRashmit approved these changes Sep 17, 2024
View reviewed changes
internal/file/file_plugin.go Show resolved Hide resolved
@sean-breen
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@sean-breen
address PR feedback
1ecc966 
    - fix message
    - ad unit test for the message and status of the failure message
@sean-breen
Copy link
Author

sean-breen commented Sep 17, 2024 •
edited
Loading

An integration test with N+ R32 failed, but passed on a re-run of the failing job.

@sean-breen sean-breen merged commit 9357a42 into v3 Sep 17, 2024
20 checks passed
@sean-breen sean-breen deleted the validation_after_config_apply branch September 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG left review comments

@RRashmit RRashmit RRashmit approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@CVanF5 CVanF5 Awaiting requested review from CVanF5

Assignees
No one assigned
Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sean-breen @oliveromahony @dhurley @aphralG @RRashmit @oCHRISo