Check error in file watcher #837

aphralG · 2024-09-12T13:23:16Z

Check there was no error before adding file watcher

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING document
I have run make install-tools and have attached any dependency changes to this pull request
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
If applicable, I have updated any relevant documentation (README.md)
If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

internal/watcher/file/file_watcher_service.go

check err

ffa7745

aphralG requested review from oliveromahony, dhurley, craigell, CVanF5, sean-breen, spencerugbo and RRashmit September 12, 2024 13:23

github-actions bot added the chore Pull requests for routine tasks label Sep 12, 2024

dhurley reviewed Sep 12, 2024

View reviewed changes

internal/watcher/file/file_watcher_service.go Show resolved Hide resolved

aphralG added 6 commits September 12, 2024 14:55

pr feedback

ad54927

pr feedback

241c593

increase test coverage

896f045

increase test coverage

838f089

Merge branch 'v3' into check-error-in-file-watcher

fe06df3

format

5415dd3

dhurley approved these changes Sep 13, 2024

View reviewed changes

dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Sep 13, 2024

oliveromahony reviewed Sep 13, 2024

View reviewed changes

internal/watcher/file/file_watcher_service.go Outdated Show resolved Hide resolved

oliveromahony approved these changes Sep 13, 2024

View reviewed changes

pr feedback

7f08e93

CVanF5 approved these changes Sep 13, 2024

View reviewed changes

aphralG merged commit 70a78e7 into v3 Sep 13, 2024
21 checks passed

aphralG deleted the check-error-in-file-watcher branch September 13, 2024 13:09

Provide feedback