-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Build container images page #827
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Build the official NGINX Agent image with Docker
section should be removed and replaced with how to pull the official NGINX Agent images.
site/content/installation-upgrade/container-environments/docker-images.md
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Jon Torre <[email protected]>
…ith docker-registry.nginx.com
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
site/content/installation-upgrade/container-environments/docker-images.md
Outdated
Show resolved
Hide resolved
…r-images.md Co-authored-by: Jon Torre <[email protected]>
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 4 out of 6 committers have signed the CLA. |
…r-images.md Co-authored-by: Jon Torre <[email protected]>
I have hereby read the F5 CLA and agree to its terms |
Added race conditions fixes to Agent v2 codebase
This all looks good. One thing for the "Run the NGINX Agent container" section. Should we give another command so an end user knows how to mount an nginx-agent.conf file? When running
|
Proposed changes
Review the docker-images page on the official documentation. Add link to the official docker images. Fix issues with existing commands.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)