-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel collector log file #806
Conversation
@@ -19,7 +20,10 @@ import ( | |||
"go.opentelemetry.io/collector/otelcol" | |||
) | |||
|
|||
const maxTimeToWaitForShutdown = 30 * time.Second | |||
const ( | |||
maxTimeToWaitForShutdown = 30 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a config setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so. We will try to wait for the otel collector to shutdown gracefully but if it takes too long we will log the issue and continue the code execution.
do we need a rotation policy to be added to the docs for this? like https://docs.nginx.com/nginx-agent/configuration/configuration-overview/#log-rotation |
scripts/testing/load/Dockerfile
Outdated
RUN mkdir /var/run/nginx-agent/ | ||
RUN mkdir /var/log/nginx-agent/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can change to a single line?
RUN mkdir /var/run/nginx-agent/ | |
RUN mkdir /var/log/nginx-agent/ | |
RUN mkdir /var/log/nginx-agent/ /var/log/nginx-agent/ |
That policy will cover the otel logs as well since its a regex that is used |
maybe an update to the docs to say that NGINX Agent and OTel logs are included as part of the policy? Just so the customers aren't surprised they got a bonus log file all of a sudden |
Proposed changes
Add OTel collector log file
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)