Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment var table to have descriptions instead of pairs #692

Closed
wants to merge 3 commits into from

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented May 28, 2024

Proposed changes

The previous iteration of this table mapped the environment variables to the CLU flags: this one instead replicates the descriptions from the flags, ensuring a user doesn't need to cross-reference them.

It also changes the table to an include, meaning it can be easily updated and re-used from a single source in the future if necessary.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

The previous iteration of this table mapped the environment variables
to the CLU flags: this one instead replicates the descriptions from the
flags, ensuring a user doesn't need to cross-reference them.

It also changes the table to an include, meaning it can be easily
updated and re-used from a single source in the future if necessary.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 0707367
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6655df617b15fd0008a9374e
😎 Deploy Preview https://deploy-preview-692--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ADubhlaoich ADubhlaoich self-assigned this May 28, 2024
I accidentally removed them during merge conflict resolution: they also
needed to be moved to the top for the sake of matching the flags, which
are alphabetized.
Copy link
Contributor

@travisamartin travisamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this MR. This rework is covered more extensively by this other MR:

https://github.com/nginx/agent/pull/701/files

@ADubhlaoich ADubhlaoich deleted the map-variables-flags branch June 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants