Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename hugo folder to site, fix product naming #527

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

Jcahilltorre
Copy link
Contributor

Proposed changes

  • Rename the Hugo documentation to site, which is site-builder agnostic
  • Correct some instances where the docs refer to the product with the determiner in front ( The NGINX agent)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Jcahilltorre Jcahilltorre self-assigned this Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65773410a10485104a2cd96a
😎 Deploy Preview https://deploy-preview-527--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added bug Something isn't working dependencies documentation Improvements or additions to documentation labels Dec 11, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b887f38) 66.13% compared to head (b8285c4) 66.14%.
Report is 8 commits behind head on main.

Files Patch % Lines
...c/extensions/nginx-app-protect/nap/nap_metadata.go 46.15% 6 Missing and 1 partial ⚠️
src/core/os.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   66.13%   66.14%           
=======================================
  Files         118      118           
  Lines       13462    13468    +6     
=======================================
+ Hits         8903     8908    +5     
- Misses       3959     3960    +1     
  Partials      600      600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jcahilltorre Jcahilltorre merged commit 6ea3eec into main Dec 11, 2023
24 of 28 checks passed
@Jcahilltorre Jcahilltorre deleted the DOC-391 branch December 11, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants