return COMMAND_STATUS_FAILURE

nginx · Sep 13, 2024 · f6df19f · f6df19f
1 parent 97c153b
commit f6df19f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/internal/file/file_plugin.go b/internal/file/file_plugin.go
@@ -205,25 +205,25 @@ func (fp *FilePlugin) handleConfigApplyRequest(ctx context.Context, msg *bus.Mes
 			ctx,
 			configApplyRequest.GetOverview().GetConfigVersion().GetInstanceId(),
 		)
-
 		if rollbackErr != nil {
 			rollbackResponse := fp.createDataPlaneResponse(
 				correlationID,
-				mpi.CommandResponse_COMMAND_STATUS_ERROR,
-				"Rollback failed",
+				mpi.CommandResponse_COMMAND_STATUS_FAILURE,
+				"Config apply failed, rollback failed",
 				configApplyRequest.GetOverview().GetConfigVersion().GetInstanceId(),
 				rollbackErr.Error())
-
 			fp.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: rollbackResponse})
+			fp.fileManagerService.ClearCache()
+
+			return
 		}
 
 		response = fp.createDataPlaneResponse(
 			correlationID,
 			mpi.CommandResponse_COMMAND_STATUS_FAILURE,
-			"Rollback failed",
+			"Config apply failed, rollback success",
 			configApplyRequest.GetOverview().GetConfigVersion().GetInstanceId(),
 			err.Error())
-
 		fp.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: response})
 		fp.fileManagerService.ClearCache()