Add default config for command (#872)

docs/features/features.md

@@ -208,4 +208,4 @@ Proper security measures and validation ensure the integrity and
 reliability of the feature management process.
 
 
-[def]: #conflictingcombinations
+[def]: #conflictingcombinations

internal/command/command_plugin.go

@@ -14,6 +14,7 @@ import (
 	"github.com/nginx/agent/v3/internal/config"
 	"github.com/nginx/agent/v3/internal/grpc"
 	"github.com/nginx/agent/v3/internal/logger"
+	pkgConfig "github.com/nginx/agent/v3/pkg/config"
 )
 
 var _ bus.Plugin = (*CommandPlugin)(nil)
@@ -27,7 +28,7 @@ type (
 		UpdateDataPlaneHealth(ctx context.Context, instanceHealths []*mpi.InstanceHealth) error
 		SendDataPlaneResponse(ctx context.Context, response *mpi.DataPlaneResponse) error
 		CancelSubscription(ctx context.Context)
-		CheckConnection() bool
+		IsConnected() bool
 		CreateConnection(ctx context.Context, resource *mpi.Resource) (*mpi.CreateConnectionResponse, error)
 	}
 
@@ -85,7 +86,7 @@ func (cp *CommandPlugin) Process(ctx context.Context, msg *bus.Message) {
 
 func (cp *CommandPlugin) processResourceUpdate(ctx context.Context, msg *bus.Message) {
 	if resource, ok := msg.Data.(*mpi.Resource); ok {
-		if !cp.commandService.CheckConnection() {
+		if !cp.commandService.IsConnected() && cp.config.IsFeatureEnabled(pkgConfig.FeatureConnection) {
 			cp.createConnection(ctx, resource)
 		} else {
 			statusErr := cp.commandService.UpdateDataPlaneStatus(ctx, resource)
@@ -150,12 +151,62 @@ func (cp *CommandPlugin) monitorSubscribeChannel(ctx context.Context) {
 
 			switch message.GetRequest().(type) {
 			case *mpi.ManagementPlaneRequest_ConfigUploadRequest:
-				cp.messagePipe.Process(newCtx, &bus.Message{Topic: bus.ConfigUploadRequestTopic, Data: message})
+				cp.handleConfigUploadRequest(newCtx, message)
 			case *mpi.ManagementPlaneRequest_ConfigApplyRequest:
-				cp.messagePipe.Process(newCtx, &bus.Message{Topic: bus.ConfigApplyRequestTopic, Data: message})
+				cp.handleConfigApplyRequest(newCtx, message)
 			default:
 				slog.DebugContext(newCtx, "Management plane request not implemented yet")
 			}
 		}
 	}
 }
+
+func (cp *CommandPlugin) handleConfigApplyRequest(newCtx context.Context, message *mpi.ManagementPlaneRequest) {
+	if cp.config.IsFeatureEnabled(pkgConfig.FeatureConfiguration) {
+		cp.messagePipe.Process(newCtx, &bus.Message{Topic: bus.ConfigApplyRequestTopic, Data: message})
+	} else {
+		slog.WarnContext(
+			newCtx,
+			"Configuration feature disabled. Unable to process config apply request",
+			"request", message,
+		)
+
+		err := cp.commandService.SendDataPlaneResponse(newCtx, &mpi.DataPlaneResponse{
+			MessageMeta: message.GetMessageMeta(),
+			CommandResponse: &mpi.CommandResponse{
+				Status:  mpi.CommandResponse_COMMAND_STATUS_FAILURE,
+				Message: "Config apply failed",
+				Error:   "Configuration feature is disabled",
+			},
+			InstanceId: message.GetConfigUploadRequest().GetOverview().GetConfigVersion().GetInstanceId(),
+		})
+		if err != nil {
+			slog.ErrorContext(newCtx, "Unable to send data plane response", "error", err)
+		}
+	}
+}
+
+func (cp *CommandPlugin) handleConfigUploadRequest(newCtx context.Context, message *mpi.ManagementPlaneRequest) {
+	if cp.config.IsFeatureEnabled(pkgConfig.FeatureConfiguration) {
+		cp.messagePipe.Process(newCtx, &bus.Message{Topic: bus.ConfigUploadRequestTopic, Data: message})
+	} else {
+		slog.WarnContext(
+			newCtx,
+			"Configuration feature disabled. Unable to process config upload request",
+			"request", message,
+		)
+
+		err := cp.commandService.SendDataPlaneResponse(newCtx, &mpi.DataPlaneResponse{
+			MessageMeta: message.GetMessageMeta(),
+			CommandResponse: &mpi.CommandResponse{
+				Status:  mpi.CommandResponse_COMMAND_STATUS_FAILURE,
+				Message: "Config upload failed",
+				Error:   "Configuration feature is disabled",
+			},
+			InstanceId: message.GetConfigUploadRequest().GetOverview().GetConfigVersion().GetInstanceId(),
+		})
+		if err != nil {
+			slog.ErrorContext(newCtx, "Unable to send data plane response", "error", err)
+		}
+	}
+}

internal/command/command_plugin_test.go

@@ -75,11 +75,11 @@ func TestCommandPlugin_Process(t *testing.T) {
 	defer commandPlugin.Close(ctx)
 
 	// Check CreateConnection
-	fakeCommandService.CheckConnectionReturnsOnCall(0, false)
+	fakeCommandService.IsConnectedReturnsOnCall(0, false)
 
 	// Check UpdateDataPlaneStatus
-	fakeCommandService.CheckConnectionReturnsOnCall(1, true)
-	fakeCommandService.CheckConnectionReturnsOnCall(2, true)
+	fakeCommandService.IsConnectedReturnsOnCall(1, true)
+	fakeCommandService.IsConnectedReturnsOnCall(2, true)
 
 	commandPlugin.commandService = fakeCommandService
 

internal/command/command_service.go

@@ -71,7 +71,7 @@ func NewCommandService(
 	return commandService
 }
 
-func (cs *CommandService) CheckConnection() bool {
+func (cs *CommandService) IsConnected() bool {
 	return cs.isConnected.Load()
 }