lock collectors

nginx · Aug 28, 2024 · d473ba2 · d473ba2
1 parent 3a729e1
commit d473ba2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/plugins/metrics.go b/src/plugins/metrics.go
@@ -71,7 +71,9 @@ func (m *Metrics) Init(pipeline core.MessagePipeInterface) {
 }
 
 func (m *Metrics) Close() {
+	m.collectorsMutex.Lock()
 	m.collectors = nil
+	m.collectorsMutex.Unlock()
 	log.Info("Metrics is wrapping up")
 }
 
@@ -336,6 +338,8 @@ func createCollectorConfigsMap(config *config.Config, binary core.NginxBinary, p
 }
 
 func (m *Metrics) updateCollectorsConfig() {
+	m.collectorsMutex.Lock()
+	defer m.collectorsMutex.Unlock()
 	log.Trace("Updating collector config")
 	for _, collector := range m.collectors {
 		if nginxCollector, ok := collector.(*collectors.NginxCollector); ok {

diff --git a/test/performance/vendor/github.com/nginx/agent/v2/src/plugins/metrics.go b/test/performance/vendor/github.com/nginx/agent/v2/src/plugins/metrics.go