Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Test Cases for RO-Crate Export with Fixed Output #487

Open
floWetzels opened this issue Jan 22, 2025 · 0 comments
Open
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@floWetzels
Copy link
Collaborator

At the moment, all RO-Crate tests only check whether exporting and then importing an ARC yields the original object. Such a test case misses certain types of code changes, e.g. editing the context semantically does not result tests failing.

I suggest there should be at least one test case checking the export of a specific ARC or Investigation against a fixed json string. Such objects already exist in the code base, e.g. in tests/TestingUtils/TestObjects.ROCrate/[email protected]. However, no test uses this file.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jan 22, 2025
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: No status
Development

No branches or pull requests

3 participants