feat: Saving file #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juliusknorr
reviewed
Jul 18, 2024
.env.example
Outdated
| @@ -7,6 +7,8 @@ TLS=false | |||
| TLS_KEY= | |||
| TLS_CERT= | |||
| JWT_SECRET_KEY=your_secret_key | |||
| WHITEBOARD_SHARED_SECRET=your_shared_secret | |||
There was a problem hiding this comment.
Do you think we could just use the JWT_SECRET_KEY as it is shared already?
juliusknorr
reviewed
Jul 18, 2024
websocket_server/roomData.js
Outdated
| if (!roomUsers.has(roomId)) { | ||
| return null | ||
| } | ||
| // TODO: Check if the user has write permissions |
There was a problem hiding this comment.
Would be still nice to address before merging.
juliusknorr
reviewed
Jul 18, 2024
| } | ||
|
|
||
| $userFolder = $this->rootFolder->getUserFolder($user->getUID()); | ||
| $file = $userFolder->getById($fileId)[0]; |
There was a problem hiding this comment.
There are a few things we should check here when getting the file, best see
for all edge cases that may occur 🙈
juliusknorr
reviewed
Jul 18, 2024
| if (!$user) { | ||
| return new DataResponse(['message' => 'Invalid user'], Http::STATUS_BAD_REQUEST); | ||
| } | ||
|
|
There was a problem hiding this comment.
We probably want to call setVolatileActiveUser to make sure the write is also in scope of the user (e.g. for creating versions and activity entries).
juliusknorr
requested changes
Jul 18, 2024
hweihwang
force-pushed
the
feat/saving-to-file
branch
from
96ffc78 to
fa14485
Compare
juliusknorr
approved these changes
Jul 23, 2024
Signed-off-by: Hoang Pham <[email protected]> feat: Saving file Signed-off-by: Hoang Pham <[email protected]> feat: Saving file Signed-off-by: Hoang Pham <[email protected]> feat: Saving file Signed-off-by: Hoang Pham <[email protected]>
juliusknorr
force-pushed
the
feat/saving-to-file
branch
from
fa14485 to
408f158
Compare
|
@hweihwang I squashed your commits into one. ;) Looks all nice and saving is smooth also with sharing involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.