Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(encryption): handle empty encryptionModules fine #50277

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 20, 2025

Backport of #50265

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

`[].find(...)` will return `undefined`.
`undefined[0]` throws an exception.
Handle this case more gracefully.

Signed-off-by: Max <[email protected]>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Jan 20, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.12 milestone Jan 20, 2025
@max-nextcloud
Copy link
Contributor

/compile amend

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport of the actual change looks good. Only missing compilation which I just triggered.

@max-nextcloud max-nextcloud marked this pull request as ready for review January 20, 2025 14:38
Signed-off-by: nextcloud-command <[email protected]>
@solracsf solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2025
@max-nextcloud max-nextcloud merged commit 994ffe1 into stable29 Jan 20, 2025
113 checks passed
@max-nextcloud max-nextcloud deleted the backport/50265/stable29 branch January 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants