perf(files_reminders): Reduce db queries on propfind

[Pytal]

Summary

• Add caching for reminders
• Reduces database queries by n number of nodes in the directory per PROPFIND

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[icewind1991]

Doing n cache lookups per propfind isn't great either. Is it possible to change the logic so all reminders in a folder can be looked up at once?

[Pytal]

Doing n cache lookups per propfind isn't great either. Is it possible to change the logic so all reminders in a folder can be looked up at once?

Any pointers for how this could be done?

[icewind1991]

In the propfind plugin, you can detect when the property is being requested as part of the propfind for a folder and contents. Then pre-load the data for the entire folder, keeping it in memory for use when the properties are requested for the individual files.

See for example:

server/apps/dav/lib/Connector/Sabre/CommentPropertiesPlugin.php

Lines 89 to 94 in 3810770

	if ($node instanceof Directory
	&& $propFind->getDepth() !== 0
	&& !is_null($propFind->getStatus(self::PROPERTY_NAME_UNREAD))
	) {
	$this->cacheDirectory($node);
	}