fix(files): more conversion tests and translate error messages #50240
+65
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skjnldsv
commented
Jan 17, 2025
•
skjnldsv
commented
- Translate displayed error messages
- Prevent wrong extension
- Reorder destination sanity checks
- Add more integration tests
skjnldsv
added
bug
3. to review
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
fix/conversion-extension
branch
from
a49a773 to
abd3cb6
Compare
elzody
approved these changes
Jan 17, 2025
susnux
reviewed
Jan 17, 2025
| @@ -72,14 +76,18 @@ public function convert(int $fileId, string $targetMimeType, ?string $destinatio | |||
| } | |||
|
|
|||
| if (!$userFolder->get($parentDir)->isCreatable()) { | |||
| throw new OCSForbiddenException(); | |||
| throw new OCSForbiddenException($this->l10n->t('You do not have permission to create a file at the specified location')); | |||
There was a problem hiding this comment.
Is this shown on the frontend? If not then it makes no sense to translate if it is only for developers (also makes debugging harder)
There was a problem hiding this comment.
Sadly not a HintException 😔
susnux
reviewed
Jan 17, 2025
susnux
reviewed
Jan 17, 2025
|
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: John Molakvoæ <[email protected]>
susnux
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.