feat(UserMountCache): Emit events for added, removed and updated mounts #50157
+178
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
reviewed
Jan 14, 2025
provokateurin
added
the
pending documentation
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/mountmanager/emit-events
branch
from
e3b1f01 to
d8c889d
Compare
provokateurin
changed the title
come-nc
reviewed
Jan 20, 2025
Comment on lines
+132
to
+134
| foreach ($changedMounts as $mountPair) { | ||
| $this->eventDispatcher->dispatchTyped(new UserMountUpdatedEvent($mountPair[0], $mountPair[1])); | ||
| } |
There was a problem hiding this comment.
$key is not needed in the event? It’s not clear to me what the string key in $changedMounts is.
There was a problem hiding this comment.
True, I only realized this myself after pushing. I can remove later, once the other parts are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist