Merge pull request #50173 from nextcloud/backport/50152/stable29

[stable29] fix(dashboard): don't initially load items of hidden api widgets
nextcloud · Jan 17, 2025 · 7499fa9 · 7499fa9
2 parents 525e865 + 5034485
commit 7499fa9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/apps/dashboard/src/DashboardApp.vue b/apps/dashboard/src/DashboardApp.vue
@@ -283,7 +283,7 @@ export default {
 
 		const apiWidgetIdsToFetch = Object
 			.values(this.apiWidgets)
-			.filter(widget => this.isApiWidgetV2(widget.id))
+			.filter(widget => this.isApiWidgetV2(widget.id) && this.layout.includes(widget.id))
 			.map(widget => widget.id)
 		await Promise.all(apiWidgetIdsToFetch.map(id => this.fetchApiWidgetItems([id], true)))
 
@@ -377,9 +377,11 @@ export default {
 			const index = this.layout.indexOf(panel.id)
 			if (!currentValue && index > -1) {
 				this.layout.splice(index, 1)
-
 			} else {
 				this.layout.push(panel.id)
+				if (this.isApiWidgetV2(panel.id)) {
+					this.fetchApiWidgetItems([panel.id], true)
+				}
 			}
 			Vue.set(this.panels[panel.id], 'mounted', false)
 			this.saveLayout()

diff --git a/dist/dashboard-main.js b/dist/dashboard-main.js
diff --git a/dist/dashboard-main.js.map b/dist/dashboard-main.js.map