Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Allow to disable automatically open the wizard #1107

Merged
merged 1 commit into from
Feb 28, 2024
Merged

enh: Allow to disable automatically open the wizard #1107

merged 1 commit into from
Feb 28, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 27, 2024 •
edited
Loading

@susnux susnux requested a review from szaimen February 27, 2024 11:54
@susnux susnux force-pushed the chore/cleanup-dead-code branch from 6988c44 to 24e67c1 Compare February 27, 2024 11:54
szaimen
szaimen reviewed Feb 27, 2024
View reviewed changes
README.md Show resolved Hide resolved
@susnux susnux force-pushed the chore/cleanup-dead-code branch 2 times, most recently from e698425 to 874b76c Compare February 27, 2024 12:28
@susnux susnux changed the title fix: Drop outdated code and add option to disable the wizard enh: Allow to disable automatically open the wizard Feb 27, 2024
@susnux susnux requested a review from szaimen February 27, 2024 12:29
szaimen
szaimen approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux force-pushed the chore/cleanup-dead-code branch from 874b76c to b38d715 Compare February 28, 2024 10:38
@susnux susnux merged commit 68ac598 into master Feb 28, 2024
46 checks passed
@susnux susnux deleted the chore/cleanup-dead-code branch February 28, 2024 13:08
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@onny
Copy link

onny commented Jun 28, 2024

Is it possible to disable the wizard through global config.php file?

@susnux
Copy link
Contributor Author

susnux commented Jun 29, 2024

@onny either with that config implemented here you can disable it globally from opening by default.
If you not even want it from being available as the "About" section of the user menu, then simply disable the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
3. to review enhancement feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show menu item if slides are disabled
3 participants
@susnux @onny @szaimen