-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cards): add card counters #6511
base: main
Are you sure you want to change the base?
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@@ -358,6 +365,13 @@ export default { | |||
this.setPageTitle(current.title) | |||
} | |||
}, | |||
stacksByBoard: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this watch is not necessary.
src/components/Controls.vue
Outdated
@@ -22,7 +22,8 @@ | |||
<div v-else-if="board" class="board-title"> | |||
<div :style="{backgroundColor: '#' + board.color}" class="board-bullet" /> | |||
<h2 dir="auto"> | |||
{{ board.title }} | |||
<span class="board__title-text">{{ board.title }}</span> | |||
<span class="board__title-counter">{{ cardsCount }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add aria-label/title for this number.
Summary
Add card counters to each stack
TODO
Checklist