Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location and description not being saved #6635

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 16, 2025

fixes #6627

@GretaD GretaD added the 3. to review Waiting for reviews label Jan 16, 2025
@GretaD GretaD self-assigned this Jan 16, 2025
@GretaD GretaD requested a review from kesselb January 16, 2025 15:14
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst ChristophWurst merged commit a0291d7 into main Jan 16, 2025
36 checks passed
@ChristophWurst ChristophWurst deleted the fix/location-descr branch January 16, 2025 15:34
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.97%. Comparing base (8699a65) to head (5348612).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6635      +/-   ##
============================================
- Coverage     22.99%   22.97%   -0.03%     
  Complexity      475      475              
============================================
  Files           252      252              
  Lines         12117    12128      +11     
  Branches       2315     2318       +3     
============================================
  Hits           2786     2786              
- Misses         9004     9015      +11     
  Partials        327      327              
Flag Coverage Δ
javascript 14.51% <ø> (-0.02%) ⬇️
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On sidebar editor, the location and description is not saved
2 participants