Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color picker size #6631

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: color picker size #6631

merged 1 commit into from
Jan 16, 2025

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 15, 2025

fixes #6584

before
Screenshot from 2025-01-15 13-08-37

after
Screenshot from 2025-01-15 13-06-45

@GretaD GretaD self-assigned this Jan 15, 2025
@GretaD GretaD added 3. to review Waiting for reviews bug labels Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.97%. Comparing base (8699a65) to head (0c1d227).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6631      +/-   ##
============================================
- Coverage     22.99%   22.97%   -0.03%     
  Complexity      475      475              
============================================
  Files           252      252              
  Lines         12117    12128      +11     
  Branches       2315     2318       +3     
============================================
  Hits           2786     2786              
- Misses         9004     9015      +11     
  Partials        327      327              
Flag Coverage Δ
javascript 14.51% <ø> (-0.02%) ⬇️
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcitworld
Copy link
Member

Maybe directly use var(--default-clickable-area) instead?

@GretaD GretaD force-pushed the fix/color-picker-size branch from 674a081 to 4787626 Compare January 15, 2025 15:03
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistent coding style

css/app-sidebar.scss Show resolved Hide resolved
css/app-sidebar.scss Outdated Show resolved Hide resolved
@GretaD GretaD force-pushed the fix/color-picker-size branch from 4787626 to 0c1d227 Compare January 16, 2025 16:36
@GretaD GretaD enabled auto-merge January 16, 2025 16:36
@GretaD GretaD merged commit 1dbc421 into main Jan 16, 2025
37 checks passed
@GretaD GretaD deleted the fix/color-picker-size branch January 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker is too large
3 participants