Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toast): add loading toast #1554

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(toast): add loading toast #1554

merged 1 commit into from
Jan 21, 2025
+45 −2

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 21, 2025 •
edited
Loading

Peek 21-01-2025 16-45

const toast = showLoading('Converting files')

// do whatever...

// then
toast.hideToast()

@skjnldsv skjnldsv added enhancement New feature or request 3. to review labels Jan 21, 2025
@skjnldsv skjnldsv requested review from susnux and artonge January 21, 2025 15:47
@skjnldsv skjnldsv self-assigned this Jan 21, 2025
@skjnldsv skjnldsv requested review from nfebe and Pytal January 21, 2025 15:47
@skjnldsv skjnldsv merged commit 8efc303 into main Jan 21, 2025
11 checks passed
@skjnldsv skjnldsv deleted the feat/toast-load branch January 21, 2025 16:15
@skjnldsv skjnldsv mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@skjnldsv skjnldsv

Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @Pytal