-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement (better) awards #1110
base: master
Are you sure you want to change the base?
Conversation
Deploy preview for history-project-dev ready! Built with commit 2be47d6 https://deploy-preview-1110--history-project-dev.netlify.com |
I think west and toyland both have awards in their comments, and maybe ritual too @samozzy |
@nhyty Full award titles in this article https://www.nsdf.org.uk/latest-news/awards-and-commendations-2016 |
Also stuff from here @samozzy https://en.wikipedia.org/wiki/Nottingham_New_Theatre#New_Theatre_at_NSDF |
Gorge Mastromas; Proof
Once you have got the looks there i will work on getting the last few years of boat party awards on here |
Same template used for awards for people and shows. YAML syntax is the same, too.
First bunch of boat party awards based on memory
For coming into w;t with like 2 weeks to go.
This now works. Just waiting on data now. |
Shock horror as I'm bad at dates |
@samozzy this seems to have broken the search description: Code: history-project/feeds/search.json Line 41 in e2a4798
It has also broken the "by award" search on the people page: Code: history-project/_plugins/people_by.rb Lines 35 to 37 in 4906121
Also came across award stuff in these scripts, not sure exactly what it does, but worth checking it hasn't broken: |
Also broken |
Will have a look at over weekend, too sleepy to do currently |
How difficult is it to link the show in the award section to the show page? |
I would suspect quite tricky as we only have the show name and you cannot do an accurate lookup for a show with just a name (they're non-unique). |
Doesn't having one of the actor's names help? |
How about using the file name - that should unique. So you'd have:
No idea how much effort that would actually be to implement, just an idea |
Also, remembered one from 2014 :)
is breaking the build
What's the state of this now? If you want me to have a look can you give me a rundown / bullet points of what to look at? 😄 |
see the 3 broken things in the top post and the post about halfway down with images showing the issues |
Awards now display in full in search results. Thanks to @johnathan99j for this
How's this looking @samozzy? |
@davidtaylorhq All the broken things are still broken :/ |
😢 I saw the "fix search display" commit and got hopeful. Will see if I can find some time to take a look soon. |
@davidtaylorhq That's just fixed how a person displays in people search |
Render more detailed information about awards. Now shows: Organisation who gave the award; year; show award was given for (where relevant).
To Do:
Broken things to fix:
<award title> (<show>), <year>
)