Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement (better) awards #1110

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Implement (better) awards #1110

wants to merge 36 commits into from

Conversation

samozzy
Copy link
Member

@samozzy samozzy commented Apr 2, 2018

Render more detailed information about awards. Now shows: Organisation who gave the award; year; show award was given for (where relevant).

To Do:

  • Not show the 'awards' and 'committees' header on the person page if none is set. (The logic exists but is not working - confuse!)
  • Add Boat Party Awards (see Boat party awards - show & people #601)
  • Display show awards on the show page (eg, Best In House Show, etc.)
  • Add links to shows

Broken things to fix:

  • Fellows page (should be populated and organised by year awarded)
  • Filter people by award (should be populated with titles of awards only)
  • People search (should display <award title> (<show>), <year>)

more awards
show_awards

samozzy added 7 commits April 2, 2018 23:37
Now displays the organisation (`org`), year and award title, as well as the show if appropriate.
34 fellowships and 1 union prize. Dates taken as graduation date.
Will close #1103
Can't just deal with a snapshot sadly.
@ntbot
Copy link
Member

ntbot commented Apr 2, 2018

Deploy preview for history-project-dev ready!

Built with commit 2be47d6

https://deploy-preview-1110--history-project-dev.netlify.com

@nhyty
Copy link
Contributor

nhyty commented Apr 3, 2018

I think west and toyland both have awards in their comments, and maybe ritual too @samozzy

@samozzy
Copy link
Member Author

samozzy commented Apr 3, 2018

@nhyty Full award titles in this article https://www.nsdf.org.uk/latest-news/awards-and-commendations-2016
Will sort now.

@nhyty
Copy link
Contributor

nhyty commented Apr 3, 2018

@nhyty
Copy link
Contributor

nhyty commented Apr 3, 2018

Once you have got the looks there i will work on getting the last few years of boat party awards on here

@samozzy
Copy link
Member Author

samozzy commented Apr 3, 2018

This now works. Just waiting on data now.

@GingertronMk1
Copy link
Member

Shock horror as I'm bad at dates

@BenWoodford76 BenWoodford76 requested a review from wjdp April 3, 2018 22:53
@davidtaylorhq
Copy link
Member

davidtaylorhq commented Apr 4, 2018

@samozzy this seems to have broken the search description:

Deploy preview:
screen shot 2018-04-04 at 15 52 55

Live site:
screen shot 2018-04-04 at 15 53 23

Code:

"award": {{ person.award | jsonify }},


It has also broken the "by award" search on the people page:
screen shot 2018-04-04 at 15 57 17

Code:

if person.data["award"] and person.data["award"].size > 0
(@people_by_award[person.data["award"]] ||= []) << person
end

Also came across award stuff in these scripts, not sure exactly what it does, but worth checking it hasn't broken:

https://github.com/newtheatre/history-project/blob/49061219476644614dabe0fda3428e1b0745752d/_plugins/awards.rb

https://github.com/newtheatre/history-project/blob/49061219476644614dabe0fda3428e1b0745752d/feeds/people-collect.json

@samozzy
Copy link
Member Author

samozzy commented Apr 4, 2018

Also broken /people/fellows leaving it with no people 😢

@wjdp
Copy link
Member

wjdp commented Apr 4, 2018

Will have a look at over weekend, too sleepy to do currently

@nhyty
Copy link
Contributor

nhyty commented Apr 6, 2018

How difficult is it to link the show in the award section to the show page?

@wjdp
Copy link
Member

wjdp commented Apr 6, 2018

I would suspect quite tricky as we only have the show name and you cannot do an accurate lookup for a show with just a name (they're non-unique).

@GingertronMk1
Copy link
Member

Doesn't having one of the actor's names help?

@davidtaylorhq
Copy link
Member

How about using the file name - that should unique. So you'd have:

award: 
  - title: Best Projection Design
    org: Experts
    year: 2015
    show: 15_16/dark_room

No idea how much effort that would actually be to implement, just an idea

nhyty added 2 commits April 7, 2018 17:33
Also, remembered one from 2014 :)
@wjdp
Copy link
Member

wjdp commented Jul 15, 2018

What's the state of this now? If you want me to have a look can you give me a rundown / bullet points of what to look at? 😄

@nhyty
Copy link
Contributor

nhyty commented Jul 15, 2018

see the 3 broken things in the top post and the post about halfway down with images showing the issues

johnathan99j added a commit to URN/urn-history-project that referenced this pull request Aug 21, 2018
Awards now display in full in search results.
Thanks to @johnathan99j for this
@davidtaylorhq
Copy link
Member

How's this looking @samozzy?

@samozzy
Copy link
Member Author

samozzy commented May 2, 2019

@davidtaylorhq All the broken things are still broken :/

@davidtaylorhq
Copy link
Member

😢 I saw the "fix search display" commit and got hopeful. Will see if I can find some time to take a look soon.

@samozzy
Copy link
Member Author

samozzy commented May 2, 2019

@davidtaylorhq That's just fixed how a person displays in people search

@wjdp wjdp marked this pull request as draft January 12, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants