Update MacSec modules to include fabric settings #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M: Update fabric-pod-policy-group for macsec interface profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M: Update macsec modules to include fabric settings
M: Update fabric-pod-policy-group for macsec interface profile [ Fix for #175 ]
Looking for insight around my use of the
typevariable. I went back and forth on whether to add it to defaults since the intent is to force a policy type (access vs fabric) depending on where the module is called from (access_policies.tf vs fabric_policies.tf). I don't know if it makes sense to give the user the ability to override that via defaults and data model input.