New share URL API #139
Merged
New share URL API #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrj
approved these changes
Nov 30, 2023
This was
linked to
issues
Nov 30, 2023
yzslab
pushed a commit
to yzslab/viser
that referenced
this pull request
Oct 20, 2024
* Add API for accessing host, port, share URL after instantiation * Deprecate old share URL api * get_share_url() => request_share_url() * Bump version * Update Record3D example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViserServer(share=True). This syntax will still work indefinitely, but will disappear from docs + fail type checks.server.request_share_url()to request a share URL. It returns a string if successful.