Make get_client_config() raise errors that are more meaningful to the user
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgodlewski
commented
Jan 13, 2025
| if "X-Neptune-Api-Token" in error.message: | ||
| raise NeptuneInvalidCredentialsError() | ||
|
|
||
| raise_for_http_status(response.status_code) |
There was a problem hiding this comment.
I'm unable to parse this suggestion, there seems to be a problem with indentation, and it looks like it's not replacing all the lines it should replace. Can you double check?
PatrykGala
reviewed
Jan 14, 2025
src/neptune_scale/net/api_client.py
Outdated
| token_urls = TokenRefreshingURLs.from_dict(response.json()) | ||
| response = get_client_config.sync_detailed(client=client) | ||
| if response.parsed is None: | ||
| raise NeptuneScaleError(message="Failed to initialize API client: invalid response from server") |
There was a problem hiding this comment.
Please add a response status in the exception message
PatrykGala
requested changes
Jan 14, 2025
kgodlewski
force-pushed
the
kg/fix-get-client-config
branch
from
f08d4a0 to
8fd053a
Compare
PatrykGala
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common case is where the user passes an invalid token, and is presented with a cryptic "unable to get client config".