fix: retry on all NeptuneRetryableError in StatusTrackingThread.check_batch #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykGala
approved these changes
Jan 13, 2025
PatrykGala
approved these changes
Jan 14, 2025
michalsosn
force-pushed
the
ms/check_batch-backoff
branch
from
d337ea3 to
f441a2f
Compare
michalsosn
force-pushed
the
ms/check_batch-backoff
branch
from
f441a2f to
71e167c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a similar change, with a similar rationale, to the one in #99
but back than I focused on SenderThread and didn't notice the same request pattern needs changing in StatusTrackingThread