Raise on logging non-increasing series step #104
Merged
+71
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kgodlewski
force-pushed
the
kg/refactor-attribute-store
branch
from
70fa6be to
3406313
Compare
kgodlewski
force-pushed
the
kg/raise-on-non-increasing-step
branch
from
0f9d36c to
e7adcf5
Compare
Even though the backend returns an error in this case as well, We want to detect this locally, so it's easier for the user to debug their code. # Conflicts: # src/neptune_scale/api/attribute.py # tests/unit/test_attribute.py
kgodlewski
force-pushed
the
kg/raise-on-non-increasing-step
branch
from
e7adcf5 to
7aa5f24
Compare
michalsosn
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the backend returns an error in this case as well, we want to detect this locally, so it's easier for the user to debug their code.