Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload support #103

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

File upload support #103

wants to merge 23 commits into from

Conversation

kgodlewski
Copy link
Contributor

@kgodlewski kgodlewski commented Dec 13, 2024 •
edited
Loading

This PR is a part of a series. It's in draft, as there will be other PRs accumulating smaller features to the same branch kg/upload-files, then we can merge everything in one swoop

What it does:

  • adds all the underlying cruft for uploading files from the worker process
  • file upload operations are submitted via a special queue in the main process, and picked up by the worker process
  • takes in-flight uploads into account when closing the run (blocks until they are completed)
  • has some very basic tests

What it does not do:

  • backend interactions are currently mocked (we're waiting for support in the backend). Files are "uploaded" as string attributes.
  • tests are very basic and will be improved in next PRs
  • docs are rudimentary, CHANGELOG is left intact for now -- once we're happy with the shape we'll take care of these as well

@kgodlewski kgodlewski changed the base branch from kg/refactor-attribute-store to kg/auto-step December 13, 2024 10:09
@kgodlewski kgodlewski changed the base branch from kg/auto-step to kg/refactor-attribute-store December 17, 2024 14:55
@kgodlewski kgodlewski changed the title Skeleton for file upload support File upload support Dec 17, 2024
@kgodlewski kgodlewski force-pushed the kg/upload-files branch 7 times, most recently from b747d4f to be854d2 Compare December 18, 2024 11:25
@kgodlewski kgodlewski force-pushed the kg/refactor-attribute-store branch from 70fa6be to 3406313 Compare December 18, 2024 15:02
@kgodlewski kgodlewski force-pushed the kg/refactor-attribute-store branch from 0bf6895 to f933b08 Compare December 18, 2024 16:58
@kgodlewski
Rename InternalQueueFeederThread
b41bcb1 
Rename the class and friends to `OperationDispatcherThread`
@kgodlewski
Add .sync.files subpackage
bc10ae6 
The package contains code for uploading files to Neptune.
@kgodlewski
verify_max_length now accepts bytes
246cb2e
@kgodlewski
Add Run.log_file()
7c07ce7 
This uses the new `sync.files` package.
@kgodlewski
Support file uploads in dict API
12628b4 
# Conflicts:
#	src/neptune_scale/api/attribute.py
@kgodlewski
Improve how we detect unsupported kwargs in dict API
8b21657
@kgodlewski
SharedVar.wait*() now return bool
4d7c125 
This is in line with `multiprocessing.Condition.wait*()`
@kgodlewski
Add very basic tests for file uploads
b2c8458
@kgodlewski
Add util.arg_to_datetime()
e8bde2b
@kgodlewski
Add ApiClient.fetch_file_storage_info()
ee68611
@kgodlewski
Move code_to_exception() to a new module
97e6ebc 
Make this function return non-optional, as it makes little sense to do
otherwise
@kgodlewski
Add timestamp to file upload queue message
d2f1235
@kgodlewski
File upload thread now submits the upload result
1f46949
@kgodlewski
Add NEPTUNE_LOG_TRACEBACKS env variable.
2dc1f87 
If true, all errors that are put in the error queue
are also logged with tracebacks.
Default: true.
@kgodlewski kgodlewski force-pushed the kg/upload-files branch 2 times, most recently from 5086372 to dd55939 Compare December 18, 2024 17:09
PatrykGala
PatrykGala requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@PatrykGala PatrykGala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Base automatically changed from kg/refactor-attribute-store to main December 19, 2024 10:24
@PatrykGala PatrykGala marked this pull request as draft December 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykGala PatrykGala PatrykGala requested changes

@michalsosn michalsosn Awaiting requested review from michalsosn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgodlewski @PatrykGala