Add a comment

neptune-ai · Jan 13, 2025 · e9855e1 · e9855e1
1 parent 7aa5f24
commit e9855e1
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/neptune_scale/api/attribute.py b/src/neptune_scale/api/attribute.py
@@ -95,6 +95,8 @@ def log(
         elif isinstance(timestamp, (float, int)):
             timestamp = datetime.fromtimestamp(timestamp)
 
+        # MetadataSplitter is an iterator, so gather everything into a list instead of iterating over
+        # it in the critical section, to avoid holding the lock for too long.
         # TODO: Move splitting into the worker process. Here we should just send messages as they are.
         chunks = list(
             MetadataSplitter(