Code review

neptune-ai · Aug 21, 2024 · cceddab · cceddab
1 parent e35876c
commit cceddab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/neptune_scale/__init__.py b/src/neptune_scale/__init__.py
@@ -112,6 +112,9 @@ def __init__(
         if resume and from_step is not None:
             raise ValueError("`resume` and `from_step` cannot be used together.")
 
+        if max_queue_size < 1:
+            raise ValueError("`max_queue_size` must be greater than 0.")
+
         project = project or os.environ.get(PROJECT_ENV_NAME)
         verify_non_empty("project", project)
         assert project is not None  # mypy

diff --git a/tests/unit/test_metadata_splitter.py b/tests/unit/test_metadata_splitter.py
@@ -196,7 +196,7 @@ def test_splitting():
     result = list(builder)
 
     # then
-    assert len(result) > 0
+    assert len(result) > 1
 
     # Every message should be smaller than max_size
     assert all(len(op.SerializeToString()) <= max_size for op in result)
@@ -242,7 +242,7 @@ def test_split_large_tags():
     result = list(builder)
 
     # then
-    assert len(result) > 0
+    assert len(result) > 1
 
     # Every message should be smaller than max_size
     assert all(len(op.SerializeToString()) <= max_size for op in result)