New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NFRT to get more robust asset downloading #12

Merged

shartte merged 1 commit into 1.21.2-dev from nfrt-assets

Aug 15, 2024

Contributor

shartte commented Aug 15, 2024 •

edited

Loading

Replace home-brew asset downloading with NFRT to get more robust (retries, reuse of launcher assets, etc.) asset downloading.

NFRT produces the JSON file used by mcp Start.java directly

Also fixes:

Config file for ART was not written using UTF-8 causing issues when paths contained non-ASCII characters
Logging in ApplyPatches was broken due to a swapped argument


          Use NFRT to get more robust asset downloading.

278955d

neoforged-pr-publishing bot commented Aug 15, 2024

Publish PR to GitHub Packages

Technici4n approved these changes

View reviewed changes

shartte merged commit 069d45c into 1.21.2-dev

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet