Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.1] Remove getters and setters from Level.java.patch #1811

Open
wants to merge 1 commit into
base: 1.21.1
Choose a base branch
from
Open

[1.21.1] Remove getters and setters from Level.java.patch #1811

wants to merge 1 commit into from

Conversation

IThundxr
Copy link
Contributor

  • These getters and setters are not needed, and just make extending Level in a multiloader mod annoying.

@neoforged-automation neoforged-automation bot added the 1.21.1 Targeted at Minecraft 1.21.1 label Dec 31, 2024
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Dec 31, 2024 •
edited
Loading

@IThundxr, this PR introduces breaking changes.
Unfortunately, this project is not accepting breaking changes right now.
Please revert them before this PR can be merged.
Last checked commit: 7728a3688f704899cb8cc55f99308c55ab405baf.

neoforge (:neoforge)

  • net/minecraft/world/level/Level
    • setDayTimePerTick(F)V: ❗ API method was removed
    • setDayTimeFraction(F)V: ⚠ API method was removed
    • advanceDaytime()J: ⚠ API method was removed
    • getDayTimeFraction()F: ⚠ API method was removed
  • net/minecraft/client/multiplayer/ClientLevel
    • setDayTimePerTick(F)V: ⚠ API method was removed
    • setDayTimeFraction(F)V: ⚠ API method was removed
    • getDayTimeFraction()F: ⚠ API method was removed

@IThundxr
Remove getters and setters from Level.java.patch
7728a36 
- These getters and setters are not needed, and just make extending Level in a multiloader mod annoying.
@IThundxr IThundxr force-pushed the pr/remove-getters-and-setters-1.20.1 branch from c4ba122 to 7728a36 Compare December 31, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.21.1 Targeted at Minecraft 1.21.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IThundxr