NameService: minor improvements, part 5 #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
nns-upd-5
branch
3 times, most recently
from
35a4c9a to
7cd55f7
Compare
Originally implemented in nspcc-dev/neofs-contract@14fc086.
And refactor GetRecords/GetAllRecords along the way, move commonly used code to a separate function. Originally introduced in nspcc-dev/neofs-contract@432c02a.
And move commonly used code to a separate methods. Originally introduced in nspcc-dev/neofs-contract@4b86891.
Creation token key from ID can be performed in a single place, there's no need to repeat the following code each time on token-related operations: ``` ByteString tokenKey = GetKey(tokenId); ```
Except for the CNAME records. Port nspcc-dev/neofs-contract@6ea4573, nspcc-dev/neofs-contract@f4762c1 and nspcc-dev/neofs-contract#170.
Originally implemented in nspcc-dev/neofs-contract@7f1ec13 and nspcc-dev/neofs-contract@f4762c1.
If conflicting records '*.domain' are present on new domain registration, then `isAvailable` should return false for this domain. `renew` should be aware of multy-fragment domains. Ref. nspcc-dev/neofs-contract@f25296b.
AnnaShaleva
force-pushed
the
nns-upd-5
branch
from
7cd55f7 to
132c454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fifth part of NNS contract update, depends on #23, #25, #26 and #27. Waiting for other parts to be merged.
Includes: