Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: set empty string as serviceId's default value #99

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

oliviarla
Copy link
Collaborator

🔗 Related Issue

⌨️ What I did

  • serviceId 값을 사용하지 않을 때 빈 문자열""를 지정하는데, 이를 기본값으로 두도록 합니다.
  • 이를 통해 DefaultCacheConfiguration을 사용자가 지정할 때 new ArcusCacheConfiguration() 만 호출해도 이미 세팅된 기본값으로 동작할 수 있습니다. 기존에는 configuration의 setServiceId를 통해 반드시 빈 문자열을 지정해줘야만 ArcusCache가 빈으로 등록되었습니다.

@oliviarla oliviarla requested a review from uhm0311 August 23, 2024 07:42
Comment on lines +90 to -91
private String serviceId = "";
private String prefix;
private String serviceId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위치를 옮긴 이유가 있나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs에 serviceId를 먼저 설명하기도 하고, prefix 생성할 때 serviceId를 먼저 사용하기도 해서 옮겼습니다.

@jhpark816 jhpark816 merged commit 1d0d5ec into naver:develop Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants