Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Change default value of wantToGetException from literal to static final constant. #85

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented Jun 14, 2024

๐Ÿ”— Related Issue

  • ๋™์ผํ•œ ์˜๋ฏธ๋ฅผ ๊ฐ–๋Š” ํ•„๋“œ์˜ ๊ธฐ๋ณธ๊ฐ’์„ ๋ฆฌํ„ฐ๋Ÿด๋กœ ๊ด€๋ฆฌํ•  ๊ฒฝ์šฐ, ํ•œ ์ชฝ๋งŒ ๊ฐ’์„ ๋ณ€๊ฒฝํ–ˆ์„ ๋•Œ ๋‹ค๋ฅธ ์ชฝ์˜ ๊ฐ’์ด ๋‹ฌ๋ผ ๋ฌธ์ œ๊ฐ€ ๋  ์ˆ˜ ์žˆ๋‹ค.

โŒจ๏ธ What I did

  • wantToGetException ํ•„๋“œ์˜ ๊ธฐ๋ณธ๊ฐ’์„ static final๋กœ ์„ ์–ธํ•˜๊ณ  ์ด๋ฅผ ์‚ฌ์šฉํ•˜๊ฒŒ ํ•ฉ๋‹ˆ๋‹ค.
  • wantToGetException ํ•„๋“œ๊ฐ€ ๊ณ„์† ์œ ์ง€๋ ์ง€ ๋ง์ง€์— ๊ด€๊ณ„ ์—†์ด, ์ ์–ด๋„ ์œ ์ง€๋˜๋Š” ๋™์•ˆ์—๋Š” ๊ธฐ๋ณธ๊ฐ’์„ ๋ฐ”๊พธ์—ˆ์„ ๋•Œ์˜ ํœด๋จผ ์—๋Ÿฌ๋ฅผ ์ค„์ด๊ธฐ ์œ„ํ•œ ์ปค๋ฐ‹์ž…๋‹ˆ๋‹ค.

@jhpark816 jhpark816 merged commit 97b51cb into naver:develop Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants