FIX: Return the value when failed to put value got from valueLoader w…

…hen wantToGetException is false.
naver · Jun 18, 2024 · 5b69404 · 5b69404
1 parent 97b51cb
commit 5b69404
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/main/java/com/navercorp/arcus/spring/cache/ArcusCache.java b/src/main/java/com/navercorp/arcus/spring/cache/ArcusCache.java
@@ -182,8 +182,7 @@ private <T> T loadValue(String arcusKey, Callable<T> valueLoader) {
       if (wantToGetException) {
         throw toRuntimeException(e);
       }
-      logger.info("failed to loadValue. error: {}, key: {}", e.getMessage(), arcusKey);
-      return null;
+      logger.info("failed to put value got from valueLoader. error: {}, key: {}", e.getMessage(), arcusKey);
     }
 
     return value;

diff --git a/src/test/java/com/navercorp/arcus/spring/cache/ArcusCacheTest.java b/src/test/java/com/navercorp/arcus/spring/cache/ArcusCacheTest.java
@@ -1037,7 +1037,7 @@ public void testGetValueLoader_Put_Exception() throws Exception {
     verify(valueLoader, times(1)).call();
     verify(lock, times(1)).lock();
     verify(lock, times(1)).unlock();
-    assertNotNull(exception);
+    assertNull(exception);
   }
 
   @Test
@@ -1072,7 +1072,7 @@ public void testGetValueLoader_Put_FutureException() throws Exception {
     verify(valueLoader, times(1)).call();
     verify(lock, times(1)).lock();
     verify(lock, times(1)).unlock();
-    assertNotNull(exception);
+    assertNull(exception);
   }
 
    @Test