Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix response string when trimmed result in bop insert. #785

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

brido4125
Copy link
Collaborator

@brido4125 brido4125 commented Sep 19, 2024

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

docker-compose๋กœ ์บ์‹œ ํด๋Ÿฌ์Šคํ„ฐ ๊ตฌ์„ฑํ•˜์—ฌ
์•„๋ž˜์˜ bop insert๋ฅผ getrim ์˜ต์…˜ ์ฃผ์–ด ์‹คํ–‰์‹œํ‚ค๋ฉด
END ๊ฐ€ ์•„๋‹Œ TRIMMED ๊ฐ€ ์‘๋‹ต์œผ๋กœ ๋‚˜์˜ต๋‹ˆ๋‹ค.

๋ฌธ์„œ๊ฐ€ ์ž˜๋ชป๋œ ๊ฑด์ง€ ๊ตฌํ˜„์ด ์ž˜๋ชป๋œ๊ฑด์ง€ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-09-19 แ„‹แ…ฉแ„’แ…ฎ 3 26 24

PR์€ ๋ฌธ์„œ๊ฐ€ ์ž˜๋ชป๋˜์—ˆ๋‹ค๊ณ  ๊ฐ€์ •ํ•˜๊ณ  ์ž‘์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@brido4125 brido4125 changed the base branch from master to develop September 19, 2024 06:35
Copy link
Collaborator

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOCS ๋‚ด์šฉ์ด ์ž˜๋ชป๋œ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ, ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๋ฅผ DOCS์—์„œ DOC์œผ๋กœ ๋ณ€๊ฒฝํ•ด ์ฃผ์„ธ์š”.

@brido4125 brido4125 changed the title DOCS: Fix response string when trimmed result in bop insert. DOC: Fix response string when trimmed result in bop insert. Sep 19, 2024
Copy link
Collaborator

@namsic namsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/naver/arcus-java-client/blob/0551f6138e1a8907cc7c1046ece3b97ba3fff27c/src/main/java/net/spy/memcached/protocol/ascii/BTreeInsertAndGetOperationImpl.java#L136-L163

java client ๊ตฌํ˜„์—๋Š” ๋ฌธ์ œ ์—†๋Š” ์ƒํƒœ์ธ๊ฐ€์š”?

  private static final OperationStatus[] INSERT_AND_GET_STATUS_ON_LINE = {
      STORED, CREATED_STORED, NOT_FOUND, ELEMENT_EXISTS, OVERFLOWED,
      OUT_OF_RANGE, TYPE_MISMATCH, BKEY_MISMATCH
  };

  private static final OperationStatus[] UPSERT_AND_GET_STATUS_ON_LINE = {
      STORED, CREATED_STORED, REPLACED, NOT_FOUND, OVERFLOWED,
      OUT_OF_RANGE, TYPE_MISMATCH, BKEY_MISMATCH
  };

์œ„ ๋ฐฐ์—ด์— END๋‚˜ TRIMMED ์—†์–ด๋„ ๋˜๋Š”์ง€?

@namsic namsic requested a review from jhpark816 September 19, 2024 07:36
@brido4125
Copy link
Collaborator Author

java client ๊ตฌํ˜„์—๋Š” ๋ฌธ์ œ ์—†๋Š” ์ƒํƒœ์ธ๊ฐ€์š”?

์•„์ง ๊ฒ€ํ†  ํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค. ํ™•์ธํ•ด๋ณผ๊ฒŒ์š”

@jhpark816
Copy link
Collaborator

@brido4125
ํ™•์ธํ•˜๊ณ , ์˜๊ฒฌ์ฃผ์„ธ์š”.

@ing-eoking
C client๋„ ํ™•์ธํ•˜๊ณ  ์˜๊ฒฌ์ฃผ์„ธ์š”.

@ing-eoking
Copy link
Collaborator

@jhpark816

@namsic ๋‹˜์ด ์ด๋ฏธ ํ™•์ธํ•˜์‹  ๋ฐ”๋กœ๋Š” C Client์—์„œ๋Š” getrim ๊ธฐ๋Šฅ์ด ์—†๋‹ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค.

@brido4125
Copy link
Collaborator Author

@jhpark816

java client๋Š” asyncBopInsertAndGetTrimmed์—์„œ getrim ์˜ต์…˜์ด ์‚ฌ์šฉ๋ฉ๋‹ˆ๋‹ค.

private static final OperationStatus[] STORE_AND_GET_ON_DATA = {TRIMMED};

handleRead์˜ ๋กœ์ง ๋‚ด์—์„œ ์œ„ ๋ฐฐ์—ด ์‚ฌ์šฉํ•ด์„œ TRIMMED ์‘๋‹ต ์ •์ƒ์ ์œผ๋กœ ํŒŒ์‹ฑํ•˜๋Š”๊ฒƒ ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค.
๋ณ„ ๋‹ค๋ฅธ ์ด์ƒ ์—†์Šต๋‹ˆ๋‹ค.

@jhpark816 jhpark816 merged commit cacf5d5 into naver:develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants